feat(mic): add start/end trim, auto trim and clip last bit of noise when tapping or clicking stop - #7706
Merged
Conversation
Member
|
I actually was going to ask if we would be able to stretch in the future to being able to trim both the start and the end ( just a "simple" pick the start and end points of the clip) - the end partly due to this, so hopefully this resolves that part of the gripe with the internal mic 🤪 |
Collaborator
Author
|
On it
|
Collaborator
Author
|
Having a very hard time with tap and enter detection, the are quite different, still ironing things |
Member
|
absolutely perfect... auto trim worked fine for the clips I tried, but the start and end trim options make it just perfect! |
pfeerick
changed the title
pfeerick
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts the last instant of a mic recording to avoid the screen tap or, even much worse, the rotary encoder click noise
Issue reported by @philmoz