chore: add sk_SK locale for Slovak custom-function sort generation - #53
Merged
Conversation
tools/cfn_sorter.sh in EdgeTX/edgetx compiles cfn_sorter.cpp against every RADIO_LANGUAGES locale, including sk_SK, to regenerate cfn_sort.cpp. This image never generated it, so any Slovak-related "Custom function sort order" CI check fails with a locale::facet runtime error. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
pfeerick
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sk_SK.UTF-8to thelocale-genlist indev/Dockerfile, alongside the other radio-language locales.Why
tools/cfn_sorter.shin EdgeTX/edgetx compilescfn_sorter.cppagainst every locale inRADIO_LANGUAGES(radio/src/CMakeLists.txt) to regenerateradio/src/cfn_sort.cpp, includingsk_SKnow that Slovak (SK) support has been added (EdgeTX/edgetx#6830). This dev image never generated that locale, so the "Custom function sort order" CI check fails for any Slovak-related PR with:sk_SK.UTF-8was already documented (but not generated) in the locale list at the top oftools/cfn_sorter.sh— this brings the dev image in sync with that.Test plan
locale -ain the built image includessk_SK.UTF-8tools/cfn_sorter.sh(which invokesLNG_SK/sk_SK.UTF-8) completes without the locale error🤖 Generated with Claude Code