fix: sort firmware version dropdown by semver instead of date - #154
Merged
Conversation
Sorting by release date interleaved versions whenever a patch was published for an older minor branch after a newer minor already existed (e.g. v2.11.6 after v2.12.0). Sort by semver on the release tag instead, for both the CloudBuild and GitHub tabs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 36.25% 36.34% +0.08%
==========================================
Files 115 116 +1
Lines 4281 4287 +6
Branches 1034 1037 +3
==========================================
+ Hits 1552 1558 +6
+ Misses 2523 2522 -1
- Partials 206 207 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
EdgeTX Buddy has been automatically deployed to Cloudflare. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2.11.6shows up afterv2.12.0).compareFirmwareReleasessemver comparator (src/shared/firmwareVersions.ts) and uses it in bothCloudFirmwareReleasesPicker.tsxandFirmwareReleasesPicker.tsx. Non-semver ids like"nightly"always sort first.Test plan
src/shared/__tests__/firmwareVersions.spec.tscovering the interleaved-order bug,nightlypinning, prerelease ordering, and edge casesFlashingWizardintegration tests still passtsc --noEmitandeslintclean on changed/new files