Skip to content

fix: sort firmware version dropdown by semver instead of date - #154

Merged
pfeerick merged 1 commit into
mainfrom
fix/sort-firmware-versions
Aug 18, 2026
Merged

fix: sort firmware version dropdown by semver instead of date#154
pfeerick merged 1 commit into
mainfrom
fix/sort-firmware-versions

Conversation

@pfeerick

Copy link
Copy Markdown
Member

Summary

  • The firmware version dropdown (CloudBuild and GitHub tabs) sorted releases by publish date, which interleaves versions whenever a patch is published for an older minor branch after a newer minor already exists (e.g. v2.11.6 shows up after v2.12.0).
  • Adds a shared compareFirmwareReleases semver comparator (src/shared/firmwareVersions.ts) and uses it in both CloudFirmwareReleasesPicker.tsx and FirmwareReleasesPicker.tsx. Non-semver ids like "nightly" always sort first.

Test plan

  • Added unit tests in src/shared/__tests__/firmwareVersions.spec.ts covering the interleaved-order bug, nightly pinning, prerelease ordering, and edge cases
  • Existing FlashingWizard integration tests still pass
  • tsc --noEmit and eslint clean on changed/new files

Sorting by release date interleaved versions whenever a patch was
published for an older minor branch after a newer minor already
existed (e.g. v2.11.6 after v2.12.0). Sort by semver on the release
tag instead, for both the CloudBuild and GitHub tabs.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 36.34%. Comparing base (9cbe78d) to head (57ecbba).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/shared/firmwareVersions.ts 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   36.25%   36.34%   +0.08%     
==========================================
  Files         115      116       +1     
  Lines        4281     4287       +6     
  Branches     1034     1037       +3     
==========================================
+ Hits         1552     1558       +6     
+ Misses       2523     2522       -1     
- Partials      206      207       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://afea8b7e.buddy-7a6.pages.dev
✅ Storybook: https://afea8b7e.buddy-7a6.pages.dev/storybook

@pfeerick
pfeerick marked this pull request as ready for review August 18, 2026 08:21
@pfeerick
pfeerick merged commit d0ff82f into main Aug 18, 2026
17 of 18 checks passed
@pfeerick
pfeerick deleted the fix/sort-firmware-versions branch August 18, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant