Repository navigation
fix(ally): return error when unable to fetch ally info in /eden ally view - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #21: returns a clear in-game error notice when
/eden ally viewdoes not receive ally information from the bridge backend or when disconnected.Details
DiscordChatFormatter.allyActivity, whenentries == null || entries.isEmpty(), returns"Unable to fetch ally info, try again later."in red with the Eden shield prefix rather than"No guild allies currently found.".EdenModClient.requestAllyView, immediately returns the error notice if the bridge client is not connected.partyCommandExecutorso stalled or dropped responses reliably notify the player.allyActivityReturnsErrorWhenEmptyinDiscordChatFormatterTest.