Skip to content

fix(radiance): account for grace period in displayed countdown and alert threshold - #36

Merged
burgerfan41 merged 1 commit into
EdenGuild:masterfrom
Good627:FINALV1RADIANCETRACKER
Oct 19, 2026
Merged

burgerfan41 merged 1 commit into
EdenGuild:masterfrom
Good627:FINALV1RADIANCETRACKER

Conversation

@Good627

@Good627 Good627 commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #20: adjusts Radiance rotation tracker countdown timers and alert thresholds to cleanly account for the configured grace period advance notice.

Details

  • Displays remaining countdown on active local Radiance as \selfDuration - grace\ (matching remote countdown behavior).
  • Cast prompt alert (\CAST RADIANCE) triggers promptly when the grace period countdown reaches 0s (i.e. \grace\ seconds before the buff expires) rather than requiring 0s of raw duration remaining.
  • Prevents false-positive alert trigger on the casting player during local cast.
  • Unit test suite updated and extended with \ estGracePeriodAlertTiming\ in \ est/tel/eden/mod/war/RadianceTrackerTest.java.

@burgerfan41
burgerfan41 merged commit cb05d64 into EdenGuild:master Oct 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants