Skip to content

Commit cc03d62

Browse files
committed
Merge remote-tracking branch 'origin/master' into ECWID-135161-reviews-api
2 parents ec01734 + 399e9d4 commit cc03d62

5 files changed

Lines changed: 22 additions & 5 deletions

File tree

src/main/kotlin/com/ecwid/apiclient/v3/ApiClientHelper.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,8 @@ private fun createAdditionalDataPolymorphicType(): PolymorphicType<FetchedReport
530530
"utm" to FetchedReportResponse.FetchedAdditionalData.AdditionalUtmData::class.java,
531531
"orders" to FetchedReportResponse.FetchedAdditionalData.AdditionalOrdersData::class.java,
532532
"customers" to FetchedReportResponse.FetchedAdditionalData.AdditionalCustomerData::class.java,
533-
"product" to FetchedReportResponse.FetchedAdditionalData.AdditionalInventoryData::class.java
533+
"inventory_product" to FetchedReportResponse.FetchedAdditionalData.AdditionalInventoryData::class.java,
534+
"product" to FetchedReportResponse.FetchedAdditionalData.AdditionalProductData::class.java,
534535
)
535536
)
536537
}

src/main/kotlin/com/ecwid/apiclient/v3/dto/productreview/request/ProductReviewSearchRequest.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import com.ecwid.apiclient.v3.dto.productreview.enums.ProductReviewStatus
77
import com.ecwid.apiclient.v3.impl.RequestInfo
88
import com.ecwid.apiclient.v3.responsefields.ResponseFields
99
import java.time.Instant
10+
import java.util.concurrent.TimeUnit
1011

1112
data class ProductReviewSearchRequest(
1213
val reviewId: String? = null,
@@ -39,10 +40,10 @@ data class ProductReviewSearchRequest(
3940
request.orderId?.let { put("orderId", it) }
4041
request.status?.let { put("status", it.toString()) }
4142
request.rating?.let { put("rating", it.toString()) }
42-
request.createdFrom?.let { put("createdFrom", it.toString()) }
43-
request.createdTo?.let { put("createdTo", it.toString()) }
44-
request.updatedFrom?.let { put("updatedFrom", it.toString()) }
45-
request.updatedTo?.let { put("updatedTo", it.toString()) }
43+
request.createdFrom?.let { put("createdFrom", TimeUnit.MILLISECONDS.toSeconds(it.toEpochMilli()).toString()) }
44+
request.createdTo?.let { put("createdTo", TimeUnit.MILLISECONDS.toSeconds(it.toEpochMilli()).toString()) }
45+
request.updatedFrom?.let { put("updatedFrom", TimeUnit.MILLISECONDS.toSeconds(it.toEpochMilli()).toString()) }
46+
request.updatedTo?.let { put("updatedTo", TimeUnit.MILLISECONDS.toSeconds(it.toEpochMilli()).toString()) }
4647
request.sortBy?.let { put("sortBy", it.name) }
4748
put("offset", request.offset.toString())
4849
put("limit", request.limit.toString())

src/main/kotlin/com/ecwid/apiclient/v3/dto/report/enums/ReportType.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ enum class ReportType {
1717
newOrdersVsRepeatOrders,
1818
topOfCustomersByOrders,
1919
inventory,
20+
topOfShippingMethodsByOrders,
21+
topOfPaymentMethodsByOrders,
2022

2123
/** finance */
2224
allRevenue,

src/main/kotlin/com/ecwid/apiclient/v3/dto/report/result/FetchedReportResponse.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,21 @@ data class FetchedReportResponse(
6262
val imageUrl: String? = null,
6363
val thumbnailUrl: String? = null,
6464
val exampleOrder: String? = null,
65+
) : FetchedAdditionalData(AdditionalDataType.INVENTORY_PRODUCT)
66+
67+
data class AdditionalProductData(
68+
val productName: String? = null,
69+
val productSmallThumbnailUrl: String? = null,
70+
val productUrl: String? = null,
71+
val productEditUrl: String? = null,
6572
) : FetchedAdditionalData(AdditionalDataType.PRODUCT)
6673

6774
enum class AdditionalDataType {
6875
UTM,
6976
ORDERS,
7077
CUSTOMERS,
7178
PRODUCT,
79+
INVENTORY_PRODUCT,
7280
}
7381
}
7482

src/test/kotlin/com/ecwid/apiclient/v3/rule/NullablePropertyRules.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,11 @@ val otherNullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf(
110110
AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalInventoryData::thumbnailUrl),
111111
AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalInventoryData::exampleOrder),
112112

113+
AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalProductData::productName),
114+
AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalProductData::productSmallThumbnailUrl),
115+
AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalProductData::productUrl),
116+
AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalProductData::productEditUrl),
117+
113118
AllowNullable(CreateBatchRequest::groupId),
114119
AllowNullable(CreateBatchRequestWithIds::groupId),
115120

0 commit comments

Comments
 (0)