Skip to content

Commit ec01734

Browse files
committed
ECWID-135161 Refactoring product reviews methods
1 parent ba50846 commit ec01734

7 files changed

Lines changed: 27 additions & 27 deletions

File tree

src/main/kotlin/com/ecwid/apiclient/v3/ApiClient.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,8 +299,8 @@ interface SlugInfoApiClient {
299299

300300
// Product reviews
301301
interface ProductReviewsApiClient {
302-
fun searchProductReviews(request: ProductReviewsSearchRequest): ProductReviewSearchResult
303-
fun searchProductReviewsAsSequence(request: ProductReviewsSearchRequest): Sequence<FetchedProductReview>
302+
fun searchProductReviews(request: ProductReviewSearchRequest): ProductReviewSearchResult
303+
fun searchProductReviewsAsSequence(request: ProductReviewSearchRequest): Sequence<FetchedProductReview>
304304
fun getProductReviewDetails(request: ProductReviewDetailsRequest): FetchedProductReview
305305
fun updateProductReviewStatus(request: ProductReviewUpdateStatusRequest): ProductReviewUpdateStatusResult
306306
fun deleteProductReview(request: ProductReviewDeleteRequest): ProductReviewDeleteResult

src/main/kotlin/com/ecwid/apiclient/v3/dto/productreview/request/ProductReviewsSearchRequest.kt renamed to src/main/kotlin/com/ecwid/apiclient/v3/dto/productreview/request/ProductReviewSearchRequest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import com.ecwid.apiclient.v3.impl.RequestInfo
88
import com.ecwid.apiclient.v3.responsefields.ResponseFields
99
import java.time.Instant
1010

11-
data class ProductReviewsSearchRequest(
11+
data class ProductReviewSearchRequest(
1212
val reviewId: String? = null,
1313
val productId: String? = null,
1414
val orderId: String? = null,
@@ -22,7 +22,7 @@ data class ProductReviewsSearchRequest(
2222
val limit: Int = 100,
2323
override val offset: Int = 0,
2424
val responseFields: ResponseFields = ResponseFields.All,
25-
) : ApiRequest, PagingRequest<ProductReviewsSearchRequest> {
25+
) : ApiRequest, PagingRequest<ProductReviewSearchRequest> {
2626
override fun toRequestInfo() = RequestInfo.createGetRequest(
2727
pathSegments = listOf(
2828
"reviews"

src/main/kotlin/com/ecwid/apiclient/v3/impl/ProductReviewsApiClientImpl.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ import com.ecwid.apiclient.v3.dto.productreview.result.*
88
class ProductReviewsApiClientImpl(
99
private val apiClientHelper: ApiClientHelper,
1010
) : ProductReviewsApiClient {
11-
override fun searchProductReviews(request: ProductReviewsSearchRequest) =
11+
override fun searchProductReviews(request: ProductReviewSearchRequest) =
1212
apiClientHelper.makeObjectResultRequest<ProductReviewSearchResult>(request)
1313

14-
override fun searchProductReviewsAsSequence(request: ProductReviewsSearchRequest) =
14+
override fun searchProductReviewsAsSequence(request: ProductReviewSearchRequest) =
1515
apiClientHelper.makeObjectResultRequest<Sequence<FetchedProductReview>>(request)
1616

1717
override fun getProductReviewDetails(request: ProductReviewDetailsRequest) =

src/test/kotlin/com/ecwid/apiclient/v3/rule/NullablePropertyRules.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ val nullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf(
159159
fetchedSlugInfoClassesNullablePropertyRules,
160160
slugInfoRequestNullablePropertyRules,
161161
fetchedProductReviewNullablePropertyRules,
162-
productReviewsMassUpdateRequestNullablePropertyRules,
163-
productReviewsSearchRequestNullablePropertyRules,
162+
productReviewMassUpdateRequestNullablePropertyRules,
163+
productReviewSearchRequestNullablePropertyRules,
164164
).flatten()
165165

166166
sealed class NullablePropertyRule<T, R>(

src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/ProductReviewsMasUpdateRequestRules.kt renamed to src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/ProductReviewMassUpdateRequestRules.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import com.ecwid.apiclient.v3.dto.productreview.request.ProductReviewMassUpdate
44
import com.ecwid.apiclient.v3.rule.NullablePropertyRule
55
import com.ecwid.apiclient.v3.rule.NullablePropertyRule.AllowNullable
66

7-
val productReviewsMassUpdateRequestNullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf(
7+
val productReviewMassUpdateRequestNullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf(
88
AllowNullable(ProductReviewMassUpdate.Filters::createdFrom),
99
AllowNullable(ProductReviewMassUpdate.Filters::createdTo),
1010
AllowNullable(ProductReviewMassUpdate.Filters::productId),
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
package com.ecwid.apiclient.v3.rule.nullablepropertyrules
2+
3+
import com.ecwid.apiclient.v3.dto.productreview.request.ProductReviewSearchRequest
4+
import com.ecwid.apiclient.v3.rule.NullablePropertyRule
5+
import com.ecwid.apiclient.v3.rule.NullablePropertyRule.AllowNullable
6+
7+
val productReviewSearchRequestNullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf(
8+
AllowNullable(ProductReviewSearchRequest::createdFrom),
9+
AllowNullable(ProductReviewSearchRequest::createdTo),
10+
AllowNullable(ProductReviewSearchRequest::orderId),
11+
AllowNullable(ProductReviewSearchRequest::productId),
12+
AllowNullable(ProductReviewSearchRequest::rating),
13+
AllowNullable(ProductReviewSearchRequest::reviewId),
14+
AllowNullable(ProductReviewSearchRequest::sortBy),
15+
AllowNullable(ProductReviewSearchRequest::status),
16+
AllowNullable(ProductReviewSearchRequest::updatedFrom),
17+
AllowNullable(ProductReviewSearchRequest::updatedTo),
18+
)

src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/ProductReviewsSearchRequestRules.kt

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)