Skip to content

Ignore actionlint's false positive for job.workflow_sha and job.workflow_repository. Closes #139 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plamber merged 3 commits into from
Sep 30, 2026
Merged

Ignore actionlint's false positive for job.workflow_sha and job.workflow_repository. Closes #139 #140

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b050ffb
Ignore actionlint's false positive for job.workflow_sha and job.workf…
plamber Sep 30, 2026
866aeb4
Pass the actionlint ignore pattern without spaces or quotes, which th…
plamber Sep 30, 2026
08b0944
Anchor the actionlint ignore on the quoted property name and say what…
plamber Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/workflow_lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
name: Workflow lint

# Reusable workflow-syntax gate for every EasyLife 365 repository.
Expand Down Expand Up @@ -44,4 +44,15 @@
- name: Check workflow files
uses: docker://rhysd/actionlint:1.7.12
with:
args: -color
# job.workflow_sha and job.workflow_repository exist on GitHub's job context (added
# 2026-04-23) and pr_compliance.yml / pr_agent_review.yml rely on them deliberately, but
# actionlint 1.7.12 (2026-03-30), the latest release, predates them and reports them as
# undefined on every pull request. Ignore only those two properties on the job context
# (the {check_run_id tail is what scopes it there) -- anything else still fails. Remove
# this once a release that knows them is pinned above.
#
# The action splits args on whitespace and does not honour quotes, so the pattern must
# contain neither: \s stands in for each space and \x22 for each double quote.
args: >-
-color
-ignore property\s\x22workflow_(sha|repository)\x22\sis\snot\sdefined\sin\sobject\stype\s\{check_run_id
Loading