Skip to content

fix(ssl): warn when the letsencrypt account key is missing but cert state exists #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrrobot47 wants to merge 2 commits into
base: develop
Choose a base branch
from
+20 −0
Open

fix(ssl): warn when the letsencrypt account key is missing but cert state exists #500

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c14b8b3
fix(ssl): warn when the letsencrypt account key is missing but cert s…
mrrobot47 Jun 30, 2026
a62ec2c
fix(ssl): correct the lost account key warning text
mrrobot47 Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/helper/Site_Letsencrypt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,13 @@ function __construct() {
private function setAcmeClient() {

if ( ! $this->repository->hasAccountKeyPair() ) {
// Missing key plus existing LE domain state means the key was lost, not a first run; warn before regenerating.
if ( $this->hasExistingLetsencryptState() ) {
\EE::warning( 'Let\'s Encrypt account key not found, but existing certificate state was detected under ' . $this->conf_dir . '. The key appears to have been lost (e.g. host migration or snapshot restore), so a new one is being generated.' );
\EE::warning( 'Existing certificates stay valid and will be renewed under a new Let\'s Encrypt account, but challenges still pending under the old account cannot be completed and must be restarted.' );
\EE::warning( 'To keep the old account, restore ' . $this->conf_dir . '/account/ from a backup before the next SSL operation.' );
}

\EE::debug( 'No account key pair was found, generating one.' );
\EE::debug( 'Generating a key pair' );

Expand All @@ -140,6 +147,19 @@ private function setAcmeClient() {

}

/**
* Checks for AcmePhp's per-domain dirs under acme-conf, which are only created after an account key exists.
* nginx-proxy/certs/ is ignored as it also holds custom/self-signed certs.
*
* @return bool True if prior LE domain state exists.
*/
private function hasExistingLetsencryptState() {
$var_domains = glob( $this->conf_dir . '/var/*', GLOB_ONLYDIR );
$cert_domains = glob( $this->conf_dir . '/certs/*', GLOB_ONLYDIR );

return ! empty( $var_domains ) || ! empty( $cert_domains );
}

private function setRepository( $enable_backup = false ) {
$this->serializer ?? $this->serializer = new Serializer(
[ new PemNormalizer(), new GetSetMethodNormalizer() ],
Expand Down
Loading