Fix Stack Out-of-Bounds Read Issue in ForwardOpen Parsing#587
Open
MrAlaskan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes an out-of-bounds read in the
Forward Openrequest path by rejecting undersized requests before they reachConnectionObjectInitializeFromMessage().Vulnerability Description
A
Forward OpenorLarge Forward Openrequest can reach the connection object parser without a minimum input length check. A short request may therefore trigger out-of-bounds reads while multiple fixed fields are decoded from the incoming buffer (see #564).Fix Logic
This fix keeps the change small and localized to
source/src/cip/cipconnectionmanager.c.The fix works as follows:
Forward OpenorLarge Forward Openg_dummy_connection_objectto a known empty state before parsingConnectionObjectInitializeFromMessage()kCipErrorNotEnoughDataThe minimum lengths used are:
35bytes forForward Open39bytes forLarge Forward OpenAfter this fix, short requests are rejected at the entry point and no longer reach the unbounded field reads in the connection object initializer.