Repository navigation
Vectorise the population decoder in numpy - #218
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #204.
process decodefits the population logistic regression and linear discriminant in numpy across windows, folds and shuffles at once, as it already did for the one-feature decoders, instead of one scikit-learn fit per fold.decoding.population_decisions, withpopulation_lda_decisions(scikit-learn'slsqrsolver with Ledoit-Wolf shrinkage) andpopulation_logistic_decisions(batched Newton steps with backtracking).region_decisionsfits the one-feature logistic regressions throughpopulation_decisions, andlogistic_decisionsis removed.decoding_tableandrolling_tabletake the population scores, nulls and weights frompopulation_decisions.fit_scoresstays as the scikit-learn reference in the tests.tests/test_process.py,docs/how-to/decoding.mdand a changelog entry.