Repository navigation
Conversation
The Settings > Infrastructure "Install Update" button reused a single, persistent hidden <input type="file"> across every click. On Windows Chrome this specific long-lived element could stop handing back a selection entirely: the native picker opens, the user picks a file, `change` fires, but `input.files` comes back empty - with no error anywhere, since nothing downstream of an empty FileList had a reason to complain. A freshly-created input with byte-for-byte identical attributes picked up the same file correctly every time, which is what led to the fix: pickFirmwareFiles() now creates a single-use input on each click and discards it afterwards, instead of reusing one long-lived element. Also hardens two related silent-failure paths surfaced while chasing this down, both real bugs independent of the root cause above: - matchesBoardBinary() built a RegExp straight from a board-reported firmwareFileName; a name containing characters that don't form a valid pattern would throw and silently abort classification for every other picked file too. Now caught and treated as "no match". - Any exception from planFiles() other than the two already-handled types was swallowed by a bare console.warn with no UI feedback. Now surfaces a proper error notification. Also added a notification for the case where a file uploads successfully but doesn't match any connected board/module/config file, so nothing was actually installed - previously silent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
chrishamm
added a commit
that referenced
this pull request
Aug 19, 2026
…518) The change handler cleared the input before reading the picked files, so Chromium returned an empty FileList and the upload never started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Settings > Infrastructure Install Update button reused a single, persistent hidden
<input type="file">element across every click. On Windows/Chrome this specific long-lived element could stop handing back a file selection entirely: the native picker opens, the user picks a file,changefires, butinput.filescomes back empty - with no error anywhere in the app, since nothing downstream of an emptyFileListhad any reason to complain. The button appeared to do nothing at all after the file dialog closed.Root cause and how it was isolated
This was tracked down through live testing against a real board (Windows/Chrome):
acceptattribute entirely made no difference..click()directly (bypassing the Vuetify button) made no difference.<input type="file">element, with attributes byte-for-byte identical to the persistent one (type,multiple,accept,hidden), picked up the same file correctly on the first try - every time, on both the Settings and Explorer pages.That isolates the fault to the one specific, long-lived DOM node itself, independent of its attributes, how it's triggered, or the page it's on. The fix:
pickFirmwareFiles()now creates a single-use<input>on every click and discards it afterwards, instead of reusing one persistent element - matching the pattern proven reliable by testing. The static<input>was removed from the template.Additional hardening found along the way
Two related silent-failure paths surfaced while chasing this down and are fixed here too, independent of the root cause above:
matchesBoardBinary()built aRegExpdirectly from a board-reportedfirmwareFileName. A name containing characters that don't form a valid pattern would throw and silently abort classification for every other picked file, not just the one board. Now caught and treated as "no match" for that board.planFiles()other than the two already-handled types (PluginBundleDetectedError,ZipExtractionError) was swallowed by a bareconsole.warnwith zero UI feedback. Now surfaces a proper error notification.Testing
vue-tsc --noEmitandnpm run buildboth pass.🤖 Generated with Claude Code