Skip to content

Pre-release - #10

Merged
DotoPototo merged 14 commits into
betafrom
fable
Jul 23, 2026
Merged

DotoPototo merged 14 commits into
betafrom
fable

Conversation

@DotoPototo

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the bubblecomplete library for a v2 pre-release by switching the module path to /v2, updating public docs/examples, and tightening correctness around path completion/validation and completion rendering on narrow terminals.

Changes:

  • Bump module/import paths to github.com/dotopototo/bubblecomplete/v2 and update README, examples, and add a v2.0.0 changelog entry.
  • Fix/guard completion rendering and Tab behavior for filesystem path completions (including narrow terminal width clamping) and expand tests for these regressions.
  • Improve validation/path error wrapping (so PathNotFound can unwrap to underlying fs/os errors) and make small hot-path perf tweaks (LRU touch rotation, Unicode-safe punctuation sorting).

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
validation.go Pass through underlying os.Stat not-exist error when producing PathNotFound.
validation_test.go Fix test-case typos; assert PathNotFound unwraps to fs.ErrNotExist.
validation_errors.go Extend errPathNotExist to store the underlying error in ValidationError.Err.
update_test.go Add regression test ensuring rendered rows never exceed terminal width on narrow terminals.
render.go Clamp titleWidth to the clamped box width; refine truncation footer gating and comments.
README.md Update pkg.go.dev links, install/import snippets, and godoc references for /v2.
pathresolve.go Refactor/condense documentation around quoting and path resolution semantics.
pathcomplete.go Make trailing-space detection token-aware; condense docs; keep path completion invariants.
pathcache.go Optimize LRU “touch” to avoid per-hit slice reallocations; clarify cache key semantics.
path_integration_test.go Add integration regressions for Tab drill-down edge cases and quoted-space pathState behavior.
model.go Minor doc clarifications for FilesystemCompletions, completion interface, and SetWidth.
history.go Doc tightening around history persistence behavior and failure handling.
go.mod Change module path to /v2.
example/main.go Update imports to /v2; ensure CPU profile file is closed on StartCPUProfile failure and via defer.
example/commands.go Update example imports to /v2.
completions.go Unicode-safe punctuation detection (avoid panic on empty/UTF-8 edge cases); doc tightening.
CHANGELOG.md Add v2.0.0 changelog entry outlining breaking changes, additions, and fixes.
bubblecomplete.go Adjust Tab no-op guard to exempt path candidates (but see review comment).
.golangci.yml Add gosmopolitan and recvcheck linters.
.github/workflows/ci.yml Run CI on beta branch pushes in addition to main.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bubblecomplete.go Resolved
@DotoPototo
DotoPototo merged commit bbca868 into beta Jul 23, 2026
5 checks passed
@DotoPototo
DotoPototo deleted the fable branch July 24, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants