Repository navigation
test: turn off CrewAI telemetry for the suite (#1202) - #1230
Merged
Merged
Conversation
CrewAI exports anonymous telemetry from a background thread. Under the dead ALL_PROXY in test_transport_proxy_mounts.py, that export opened a socket while no_sockets patches socket.connect process-wide. The lowest-direct (crewai) nightly leg then failed on CrewAI's traffic, not ours, whenever the export landed inside a test's window. conftest now sets CREWAI_DISABLE_TELEMETRY=true at load, next to the LiteLLM cost-map switch. The switch is honoured by crewai 1.15.3 (the floor) through 1.15.23. OTEL_SDK_DISABLED would also work but is cleared per test with the other OTEL_* vars. A guard test fails if CrewAI stops honouring the switch. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1202. It fixes the CrewAI half here. The ADK
after_model_callbackfailure, the other half, is already fixed by #1214 (merged after the last red nightly ran). ADK 2.13.0 passes on currentdevelop.Cause
CrewAI exports anonymous telemetry from a background thread.
test_transport_proxy_mounts.pysets a deadALL_PROXY(127.0.0.1:9), and itsno_socketsfixture patchessocket.connectfor the whole process. When CrewAI's export landed inside a test's window,test_sync_simulate_stays_offline_under_proxy[ALL_PROXY]failed on CrewAI's traffic, not ours. The failure depends on timing, which is why thelowest-direct (crewai)leg went red at random.Fix (test-only)
tests/conftest.pysetsCREWAI_DISABLE_TELEMETRY=truewhen the suite loads, next to the existingLITELLM_LOCAL_MODEL_COST_MAPswitch. crewai 1.15.3 (the floor) and 1.15.23 both honour it.OTEL_SDK_DISABLEDwould also work, but the autouse env fixture clears everyOTEL_*var per test.test_crewai_telemetry_is_off_for_the_suite, fails if CrewAI stops honouring the switch, so the nightly shows the real cause.Verification
CREWAI_DISABLE_TELEMETRY=false.No ADR needed (test-only change).
🤖 Generated with Claude Code