Repository navigation
chore(deps): move the pre-commit ruff rev with the lint lock - #1213
Open
tbolis-at-mulesoft wants to merge 1 commit into
Open
tbolis-at-mulesoft wants to merge 1 commit into
tbolis-at-mulesoft wants to merge 1 commit into
Conversation
The lock refresh in #1206 takes ruff 0.17.1 -> 0.17.2, but .pre-commit-config.yaml still pins the ruff-pre-commit rev at v0.17.1, so tests/unit/test_noxfile.py fails on every leg of the bump PR (15 jobs). The same hand bump was needed in #1143 and #1165. scripts/compile_constraints.py now rewrites the ruff-pre-commit `rev:` and the lint-imports hook's import-linter pin from the typecheck-and-lint lock it just compiled (and --check reports the file stale), and lock-refresh.yml commits .pre-commit-config.yaml with the lock. The hooks follow whatever ruff the lock holds, so develop keeps v0.17.1 with its 0.17.1 lock and the next refresh ships v0.17.2 alongside ruff==0.17.2. No ceiling (§8.4). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1206 (the lock-refresh PR this unblocks). No tracking issue was filed for the ruff 0.17.2 bump: it arrived through the nightly lock refresh, not a
framework-releaseissue.Summary
ruff0.17.1 -> 0.17.2 inpython/constraints/typecheck-and-lint-py3.11.txt, but.pre-commit-config.yamlstill pins the ruff-pre-commitrev: v0.17.1.tests/unit/test_noxfile.py::test_pre_commit_runs_the_lint_jobs_tool_versionsholds the two equal, so all 15 test legs of run 39946600694 fail withAssertionError: assert 'v0.17.1' == 'v0.17.2'. chore(deps): ship the framework releases in the nightly lock refresh #1143 and chore(deps): ship the framework releases in the nightly lock refresh (#1156) #1165 both had to bump the rev by hand. A hand push tobot/lock-refreshdoesn't stick, because the workflow rebuilds that branch fromdevelop.scripts/compile_constraints.pynow rewrites the ruff-pre-commitrev:and the lint-imports hook'simport-linter==pin from the typecheck-and-lint lock it just compiled, as a text edit so the file's comments survive.--checknow lists.pre-commit-config.yamlwhen its pins are stale.lock-refresh.ymladds../.pre-commit-config.yamlto the bump commit.developkeepsv0.17.1with its 0.17.1 lock, and the next refresh shipsv0.17.2together withruff==0.17.2. No version ceiling (§8.4). Nosrc/change, so the layered-import rule (§1.1) is not affected.docs/ci.md(lock-refresh section), the CONTRIBUTING hand-refresh steps, and the pre-commit config header comment.Test plan
tests/unit/test_pre_commit_lock_sync.py(7 tests). Ondevelopit fails at collection because the sync doesn't exist yet. After the fix all 7 pass. They check: a ruff 0.17.2 lock moves the rev from v0.17.1 to v0.17.2; an import-linter release moves the hook dependency; only those two lines change; the committed hooks already match the committed lock; a missing pin or hook raises an error;lock-refresh.ymlstages.pre-commit-config.yaml.bot/lock-refreshlint lock in place,pytest tests/unit/test_noxfile.pygives1 failed, 74 passed. After running the sync it gives75 passed, with the rev rewritten tov0.17.2and nothing else changed.python scripts/compile_constraints.py --check(live uv resolve) exits 1 and lists.pre-commit-config.yamlwith the stale locks. That is expected, because upstream has moved since the last lock.python/in a venv withruff==0.17.2andimport-linter==2.15:ruff check .all passed,ruff format --check .295 files already formatted,mypyno issues in 91 source files,lint-imports9 kept / 0 broken,vultureclean,pytest -q3477 passed / 264 skipped / 15 deselected.actionlintandzizmor --offlineonlock-refresh.yml: clean.scripts/check_commit_identities.py origin/develop..HEAD: clean.verify_frameworks.py: exit 0. No adapter is affected, so no framework is installed.Post-deploy steps
After this merges, re-run
lock-refresh.ymlondevelop(gh workflow run lock-refresh.yml --ref develop), or wait for the next green nightly. It rebuildsbot/lock-refreshand #1206 withrev: v0.17.2, and that clears the 15 failing jobs. Merge #1206 once its CI is green.🤖 Generated with Claude Code