Skip to content

Updated handleChangeEvent logic to handle switching posts mid-execution #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cairocoder01 merged 1 commit into from
Oct 6, 2026
Merged

Updated handleChangeEvent logic to handle switching posts mid-execution #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 32 additions & 21 deletions src/services/componentService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ export default class ComponentService {
* @returns {Promise<void>}
*/
async handleChangeEvent(event) {
const startingId = this.postId;
const details = event.detail;
if (details) {
const { field, newValue, oldValue, remove } = details;
Expand All @@ -403,8 +404,10 @@ export default class ComponentService {
oldValue,
);

event.target.removeAttribute('saved');
event.target.setAttribute('loading', true);
if (startingId === this.postId) {
event.target.removeAttribute('saved');
event.target.setAttribute('loading', true);
}

if (component === 'dt-number') {
// Debounce updates for dt-number component
Expand Down Expand Up @@ -434,17 +437,21 @@ export default class ComponentService {
}),
);

event.target.removeAttribute('loading');
event.target.setAttribute('error', '');
event.target.setAttribute('saved', true);
if (startingId === this.postId) {
event.target.removeAttribute('loading');
event.target.setAttribute('error', '');
event.target.setAttribute('saved', true);
}
} catch (error) {
console.error(error);
event.target.removeAttribute('loading');
event.target.setAttribute('invalid', true); // this isn't hooked up yet
event.target.setAttribute(
'error',
error.message || error.toString(),
);
if (startingId === this.postId) {
event.target.removeAttribute('loading');
event.target.setAttribute('invalid', true); // this isn't hooked up yet
event.target.setAttribute(
'error',
error.message || error.toString(),
);
}
}
},
1000,
Expand Down Expand Up @@ -487,19 +494,23 @@ export default class ComponentService {
}),
);

if (component === 'dt-location-map' || component === 'dt-multi-text-groups') {
const componentTarget = event.target;
componentTarget.value = apiResponse[field];
}
if (startingId === this.postId) {
if (component === 'dt-location-map' || component === 'dt-multi-text-groups') {
const componentTarget = event.target;
componentTarget.value = apiResponse[field];
}

event.target.removeAttribute('loading');
event.target.setAttribute('error', '');
event.target.setAttribute('saved', true);
event.target.removeAttribute('loading');
event.target.setAttribute('error', '');
event.target.setAttribute('saved', true);
}
} catch (error) {
console.error(error);
event.target.removeAttribute('loading');
event.target.setAttribute('invalid', true); // this isn't hooked up yet
event.target.setAttribute('error', error.message || error.toString());
if (startingId === this.postId) {
event.target.removeAttribute('loading');
event.target.setAttribute('invalid', true); // this isn't hooked up yet
event.target.setAttribute('error', error.message || error.toString());
}
}
}
}
Expand Down
Loading