Skip to content

GO-53: Stop DT Home launcher logging magic-link URLs to the error log #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corsacca merged 1 commit into from
Oct 23, 2026
Merged

GO-53: Stop DT Home launcher logging magic-link URLs to the error log #2943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions dt-apps/dt-home/admin/home-admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,9 +826,6 @@ private function handle_app_action() {
$submitted_color = sanitize_text_field( wp_unslash( $_POST['app_color'] ?? '' ) );
$form_original_color = sanitize_text_field( wp_unslash( $_POST['app_color_original'] ?? '' ) );

// Debug logging (remove in production)
error_log( 'DT Home: App color update - Submitted: ' . $submitted_color . ', Original: ' . ( $original_color ?: 'empty' ) . ', Form Original: ' . $form_original_color );

// Determine if we should update the color
// If original had no color (empty string) and submitted is #cccccc (placeholder), don't update
// Otherwise, update the color
Expand Down
4 changes: 0 additions & 4 deletions dt-apps/dt-home/frontend/partials/launcher-bottom-nav.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@
// For custom apps, just need to be app-type (they may not have magic_link_meta)
return true;
});

// Debug logging
error_log( 'DT Home Launcher Nav: Total apps: ' . count( $apps ) );
error_log( 'DT Home Launcher Nav: Filtered app-type apps: ' . count( $filtered_apps ) );
?>
<div class="dt-launcher-bottom-nav">
<div class="nav-container">
Expand Down
3 changes: 0 additions & 3 deletions dt-apps/dt-home/magic-link-home-app.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@ private function get_target_app_url() {
// Check if app_url parameter is present (for cross-domain custom apps)
if ( isset( $_GET['app_url'] ) && ! empty( $_GET['app_url'] ) ) {
$app_url = esc_url_raw( wp_unslash( $_GET['app_url'] ) );
error_log( 'DT Home: Using app_url parameter for cross-domain app: ' . $app_url );
return $app_url;
}

Expand Down Expand Up @@ -332,7 +331,6 @@ private function get_target_app_url() {
public function maybe_show_launcher_wrapper() {
// Check if launcher parameter is present - if so, show wrapper page instead
if ( $this->has_launcher_parameter() ) {
error_log( 'DT Home: launcher=1 detected in dt_blank_head, showing wrapper page' );
$this->show_launcher_wrapper();
// show_launcher_wrapper() will exit, so this won't continue
}
Expand All @@ -343,7 +341,6 @@ public function maybe_show_launcher_wrapper() {
*/
private function show_launcher_wrapper() {
$target_app_url = $this->get_target_app_url();
error_log( 'DT Home: Showing launcher wrapper for URL: ' . $target_app_url );

// Get Magic URL for the target app so we can use the parts to determine the user ID
$request_uri = isset( $_SERVER['REQUEST_URI'] ) ? esc_url_raw( wp_unslash( $_SERVER['REQUEST_URI'] ) ) : '';
Expand Down
Loading