Skip to content

Security: Require a nonce-protected POST to delete a custom role (GO-54) #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corsacca merged 1 commit into from
Oct 23, 2026
Merged

Security: Require a nonce-protected POST to delete a custom role (GO-54) #2942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions dt-core/admin/menu/tabs/tab-custom-roles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,14 @@ private function delete_action() {
return;
}

if ( !isset( $_GET['confirm'] ) ) {
if ( !isset( $_POST['role_delete_nonce'] ) ) {
$this->view_delete();
return;
}

$slug = sanitize_text_field( wp_unslash( $_GET['role'] ) );
if ( !wp_verify_nonce( sanitize_key( $_POST['role_delete_nonce'] ), 'role_delete_' . $slug ) ) {
$this->show_error( new WP_Error( 401, __( 'Unauthorized', 'disciple_tools' ) ) );
$this->view_delete();
return;
}
Expand Down Expand Up @@ -841,12 +848,17 @@ class="button button-large"
>
<?php esc_html_e( 'Cancel', 'disciple_tools' ); ?>
</a>
<a href="<?php echo esc_url( $this->url_base . '&' . http_build_query( [ 'action' => 'delete', 'role' => $key, 'confirm' => true ] ) ) ?>"
class="button button-primary button-large"
title=" <?php esc_html_e( 'Delete Role', 'disciple_tools' ); ?>"
>
<?php esc_html_e( 'Delete Role', 'disciple_tools' ); ?>
</a>
<form method="post"
action="<?php echo esc_url( $this->url_base . '&' . http_build_query( [ 'action' => 'delete', 'role' => $key ] ) ) ?>"
style="display: inline;">
<?php wp_nonce_field( 'role_delete_' . $key, 'role_delete_nonce', false ); ?>
<button type="submit"
class="button button-primary button-large"
title=" <?php esc_html_e( 'Delete Role', 'disciple_tools' ); ?>"
>
<?php esc_html_e( 'Delete Role', 'disciple_tools' ); ?>
</button>
</form>
</div>

<?php
Expand Down
Loading