Preserve symlinks when copying macOS Swift framework bundles into app bundles - #5879
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As things stand, installing a built .framework into Contents/Frameworks followed every symlink instead of recreating it, so it copied the versioned Versions/Current, executable, and Resources links, and codesign rejects it as
bundle format is ambiguous (could be app or framework).I propose to recreate each symlink instead of resolving it when copying a built artifact into the bundle, with a regression test that rebuilds the exact framework layout from the report and asserts the links survive.
This pairs with #5864, which signs each embedded framework before the app, as that PR needs a correctly shaped bundle to sign, and this one needs #5864's signing step for the signature to actually cover the plugin.