Repository navigation
Conversation
hovinen
added this pull request to stack #28
October 2, 2026 13:23
hovinen
force-pushed
the
add-by_role-hidden
branch
from
October 2, 2026 13:33
805d6f1 to
8415e17
Compare
ealmloff
approved these changes
Oct 10, 2026
hovinen
force-pushed
the
add-by_role-hidden
branch
from
October 16, 2026 19:03
6a7f952 to
b4a4283
Compare
This uses the `aria-hidden` attribute which determines whether the node is hidden from assistive technology. Items which are hidden from the ARIA altogether by virtue of the HTML `hidden` attribute or the CSS properties `display: none` or `visibility: hidden` still cannot be queried with `by_role`, since they do not appear in the ARIA tree at all as per specification.
hovinen
force-pushed
the
add-by_role-hidden
branch
from
October 23, 2026 07:06
b4a4283 to
07f7a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the
aria-hiddenattribute which determines whether the node is hidden from assistive technology.Items which are hidden from the ARIA altogether by virtue of the HTML
hiddenattribute or the CSS propertiesdisplay: noneorvisibility: hiddenstill cannot be queried withby_role, since they do not appear in the ARIA tree at all as per specification.Following Playwright, the default is now to exclude hidden elements, but one can include them (or restrict to match them only) via methods on
QueryByRole.