Repository navigation
Conversation
hovinen
added this pull request to stack #28
October 2, 2026 08:36
hovinen
force-pushed
the
use-matcher-in-having-name
branch
from
October 2, 2026 08:38
f8b60a4 to
35c2bdf
Compare
ealmloff
approved these changes
Oct 10, 2026
hovinen
force-pushed
the
use-matcher-in-having-name
branch
from
October 16, 2026 19:03
3b12a62 to
7973926
Compare
Previously, the parameter to `having_name` was a string, which limited what could be done with the method and resulted in implicit behaviour. Namely, it was not clear that the a matching element would have an accessible name which _contains_ the given string. Also, it was not possible to match by regex, which Playwright [supports](https://playwright.dev/docs/api/class-page#page-get-by-role-option-name). This changes the parameter into a `Matcher<String>` so that _any_ matcher against strings can be used. This includes string containment, case-insensitive matching, and regular expressions.
hovinen
force-pushed
the
use-matcher-in-having-name
branch
from
October 23, 2026 07:06
7973926 to
11b4c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the parameter to
having_namewas a string, which limited what could be done with the method and resulted in implicit behaviour. Namely, it was not clear that the a matching element would have an accessible name which contains the given string. Also, it was not possible to match by regex, which Playwright supports.This changes the parameter into a
Matcher<String>so that any matcher against strings can be used. This includes string containment, case-insensitive matching, and regular expressions.