Repository navigation
Conversation
hovinen
added this pull request to stack #28
September 25, 2026 14:20
ealmloff
force-pushed
the
add-expect-no-matching-element
branch
from
September 26, 2026 04:19
783fdae to
33702c9
Compare
ealmloff
approved these changes
Oct 10, 2026
hovinen
force-pushed
the
add-expect-no-matching-element
branch
from
October 16, 2026 19:03
33702c9 to
af07012
Compare
Previously, it was a little awkward to assert that a given element was _not_ in the DOM. One could do so with `query_all(is_empty())`, but this is not so discoverable. This adds a method `expect_no_matching_element` to `ElementCondition` which directly expresses that no such element should exist. It was necessary to make this its own expectation method rather than using a matcher, since matchers are only triggered once an element is found.
hovinen
force-pushed
the
add-expect-no-matching-element
branch
from
October 23, 2026 07:06
af07012 to
c250a48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, it was a little awkward to assert that a given element was not in the DOM. One could do so with
query_all(is_empty()), but this is not so discoverable.This adds a method
expect_no_matching_elementtoElementConditionwhich directly expresses that no such element should exist. It was necessary to make this its own expectation method rather than using a matcher, since matchers are only triggered once an element is found.