Repository navigation
Conversation
hovinen
added this pull request to stack #28
September 25, 2026 13:28
ealmloff
force-pushed
the
fix-description-for-attribute-matcher
branch
from
September 26, 2026 04:19
31cd940 to
8e4bbf7
Compare
ealmloff
approved these changes
Oct 10, 2026
hovinen
force-pushed
the
fix-description-for-attribute-matcher
branch
from
October 16, 2026 19:03
8e4bbf7 to
b5395db
Compare
It had a copy-and-paste bug where it would show the same mismatch description as for `inner_html`. In particular, it would not show which attribute was incorrect/missing. This fixes the mismatch description and adds a suitable unit test.
hovinen
force-pushed
the
fix-description-for-attribute-matcher
branch
from
October 23, 2026 07:06
b5395db to
53d86a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It had a copy-and-paste bug where it would show the same mismatch description as for
inner_html. In particular, it would not show which attribute was incorrect/missing.This fixes the mismatch description and adds a suitable unit test.