Repository navigation
Fix FilterEffect size assertion on 32-bit x86 - #120
Merged
Merged
Conversation
On i686, 64-bit fields only have 4-byte alignment, so FilterEffect is 84 bytes rather than the 88 bytes seen on other 32-bit targets such as armv7 and wasm32. Assert the size per architecture.
nicoburns
approved these changes
Oct 20, 2026
nicoburns
left a comment
nicoburns
left a comment
Member
There was a problem hiding this comment.
We might want to just have fewer assertions, but I guess this is an improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On i686, 64-bit fields only have 4-byte alignment, so FilterEffect is 84 bytes rather than the 88 bytes seen on other 32-bit targets such as armv7 and wasm32. Assert the size per architecture.