Skip to content

Initial Super Resolution integration#776

Closed
MikhailGorobets wants to merge 7 commits intoDiligentGraphics:super_resolutionfrom
MikhailGorobets:super_resolution
Closed

Initial Super Resolution integration#776
MikhailGorobets wants to merge 7 commits intoDiligentGraphics:super_resolutionfrom
MikhailGorobets:super_resolution

Conversation

@MikhailGorobets
Copy link
Copy Markdown
Contributor

@MikhailGorobets MikhailGorobets commented Mar 4, 2026

No description provided.

github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 4, 2026
View reviewed changes
Comment thread Graphics/GraphicsEngine/interface/GraphicsTypes.h

SUPER_RESOLUTION_SPATIAL_CAP_FLAG_LAST = SUPER_RESOLUTION_SPATIAL_CAP_FLAG_NATIVE
};
DEFINE_FLAG_ENUM_OPERATORS(SUPER_RESOLUTION_SPATIAL_CAP_FLAGS)

Check warning

Code scanning / PREfast

Did you forget to initialize an enum constant, or intend to use another type?.

Did you forget to initialize an enum constant, or intend to use another type?.
@MikhailGorobets MikhailGorobets force-pushed the super_resolution branch 4 times, most recently from 9e43e4f to 6559b6c Compare March 4, 2026 09:05
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 5, 2026
View reviewed changes
Comment thread Graphics/GraphicsEngineD3D12/include/SuperResolutionD3D12Impl.hpp

~SuperResolutionD3D12Impl();

IMPLEMENT_QUERY_INTERFACE_IN_PLACE(IID_SuperResolution, TSRUpscalerBase)

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory Warning

A stack address which arrived via a
parameter
Loading
may be assigned to a non-local variable.
Comment thread Graphics/GraphicsEngine/include/RenderDeviceBase.hpp
}

template <typename... ExtraArgsType>
void CreateSuperResolutionImpl(ISuperResolution** ppUpscaler, const SuperResolutionDesc& Desc, const ExtraArgsType&... ExtraArgs)

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable ExtraArgs is not used.
Comment thread Graphics/GraphicsEngine/include/RenderDeviceBase.hpp
}

template <typename... ExtraArgsType>
void CreateSuperResolutionImpl(ISuperResolution** ppUpscaler, const SuperResolutionDesc& Desc, const ExtraArgsType&... ExtraArgs)

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable ExtraArgs is never read.
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 6, 2026
View reviewed changes
Comment thread Graphics/GraphicsEngineD3D12/include/SuperResolutionD3D12Impl.hpp

~SuperResolutionD3D12Impl();

IMPLEMENT_QUERY_INTERFACE_IN_PLACE(IID_SuperResolution, TSRUpscalerBase)

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory

A stack address which arrived via a [parameter](1) may be assigned to a non-local variable.
Comment thread Graphics/GraphicsEngine/include/RenderDeviceBase.hpp
}

template <typename... ExtraArgsType>
void CreateSuperResolutionImpl(ISuperResolution** ppUpscaler, const SuperResolutionDesc& Desc, const ExtraArgsType&... ExtraArgs)

Check notice

Code scanning / CodeQL

Unused local variable

Variable ExtraArgs is not used.
Comment thread Graphics/GraphicsEngine/include/RenderDeviceBase.hpp
}

template <typename... ExtraArgsType>
void CreateSuperResolutionImpl(ISuperResolution** ppUpscaler, const SuperResolutionDesc& Desc, const ExtraArgsType&... ExtraArgs)

Check notice

Code scanning / CodeQL

Unused static variable

Static variable ExtraArgs is never read.
@MikhailGorobets MikhailGorobets force-pushed the super_resolution branch 3 times, most recently from 58431b0 to 042d197 Compare March 6, 2026 12:17
@MikhailGorobets MikhailGorobets deleted the super_resolution branch March 28, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheMostDiligent TheMostDiligent Awaiting requested review from TheMostDiligent

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MikhailGorobets @github-advanced-security