Add low-rank waveform decomposition pipeline - #37
Merged
Conversation
osheasienna
force-pushed
the
agent/add-lowrank-waveform-decomposition
branch
from
August 13, 2026 12:39
0cebaea to
0ea2735
Compare
AdrienGordon
marked this pull request as ready for review
August 13, 2026 14:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lowrank_waveform_decompositionpipeline that consumes the shared beat-aligned segment waveform stateWhy
The AngioEye low-rank waveform analysis needed a native EyeFlow implementation that reuses the existing velocity pipeline and follows the endpoint definitions in the
svd_endpointsreference manuscript.Endpoint definitions
R0is the median centered-waveform RMS;TPRis retained only as a compatibility aliasrho_m = R_m / R0, withrho0 = 1alphacompares retained higher-mode energy with Mode 1G1is the relative gap between the first two singular valuesValidation
python -m unittest test.test_lowrank_waveform_decomposition -v: 9 passedruff check --select E,F,I ...: passedtest_run_service.RunServiceTests.test_recursive_folder_expansion_is_sorted