Repository navigation
feat(graph-proxy): add trigger namespace querying - #1743
Merged
Merged
Conversation
Oli-Jones475
force-pushed
the
query-trigger-namespace
branch
from
October 16, 2026 07:56
b6d088c to
f8d8d56
Compare
hazdl
reviewed
Oct 16, 2026
hazdl
approved these changes
Oct 16, 2026
JamesDoingStuff
requested changes
Oct 19, 2026
JamesDoingStuff
left a comment
JamesDoingStuff
left a comment
Contributor
There was a problem hiding this comment.
I realise I never wrote any details in this ticket - sorry! - but would you mind changing the field name from namespace to visit please, to match the name of the parameter used to set it? Namespace is just how it's implemented internally.
I also think it would also be good if the triggers that exist in the events namespace returned "all" for visit, to show that they will run jobs in all visits, but that can be future work if necessary
Oli-Jones475
force-pushed
the
query-trigger-namespace
branch
2 times, most recently
from
October 19, 2026 09:53
3bbbccf to
8672375
Compare
JamesDoingStuff
approved these changes
Oct 19, 2026
JamesDoingStuff
left a comment
JamesDoingStuff
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks! One suggestion that might make user-facing docstring clearer
Rename namespace field to visit Write events namespace as any for visit Fix tests Handle None case properly Test unknown case Format Update backend/graph-proxy/src/graphql/triggers.rs Co-authored-by: James Gilbert <152407564+JamesDoingStuff@users.noreply.github.com>
Oli-Jones475
force-pushed
the
query-trigger-namespace
branch
from
October 19, 2026 10:33
4bf4d3c to
1480773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow querying of the trigger namespace through graph proxy