Skip to content

Support ispyb deposition for jungfrau rotation scans #1638

Open
olliesilvester wants to merge 7 commits intomainfrom
1357_jf_ispyb_deposition
Open

Support ispyb deposition for jungfrau rotation scans #1638
olliesilvester wants to merge 7 commits intomainfrom
1357_jf_ispyb_deposition

Conversation

@olliesilvester
Copy link
Copy Markdown
Contributor

@olliesilvester olliesilvester commented Feb 19, 2026

Partially fixes #1357 . Still need to address #1357 (comment) after this PR

Requires DiamondLightSource/dodal#1931

Link to dodal PR (if required): #XXX
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@olliesilvester olliesilvester changed the title 1357 jf ispyb deposition Support ispyb deposition for jungfrau rotation scans Feb 19, 2026
@olliesilvester olliesilvester added the jungfrau Changes relating to the jungfrau detector label Feb 20, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.83%. Comparing base (e31a3ff) to head (7822e1a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1638   +/-   ##
=======================================
  Coverage   92.82%   92.83%           
=======================================
  Files         155      153    -2     
  Lines        8656     8638   -18     
=======================================
- Hits         8035     8019   -16     
+ Misses        621      619    -2     
Components Coverage Δ
i24 SSX 77.32% <ø> (ø)
hyperion 98.20% <100.00%> (-0.03%) ⬇️
other 98.25% <100.00%> (+0.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olliesilvester olliesilvester marked this pull request as ready for review February 23, 2026 10:25
@olliesilvester olliesilvester requested a review from a team as a code owner February 23, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jungfrau Changes relating to the jungfrau detector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jungfrau: Initial ispyb deposition

1 participant