Skip to content

attach_data_session_metadata_decorator should decorate with instrument, visit_id and scan_number #666

Closed

Description

@DiamondJoseph

This information is required for forwarding processing requests to central processing message bus, but is currently only available by decomposing other values. They should be passed explicitly and tested to ensure behaviour is consistent.

Acceptance Criteria

  • When running a plan that has been decorated by the above decorator
  • "visit" or "visit_id" is a key on the start document that contains the identifier of the visit (e.g. cm12345-6)
  • "scan_number", "scan_identifier" or similar is also a key that contains the scan number (the number that is mutually increased with GDA)
  • "instrument" is another key, and its value is the identifier of the beamline, e.g. "p45", "i20-1"

Activity

  1. added
    enhancementNew feature or request
    pythonPull requests that update Python code
    on Dec 2, 2024
  2. oliwenmandiamond commented on Sep 8, 2026

    @oliwenmandiamond
    Contributor

    No longer relevant, done on blueapi side and attach_data_session_metadata has been removed #2201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestpythonPull requests that update Python code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions