Repository navigation
ViSR sprint: server-side improvements - #19
Draft
hyperrealist wants to merge 2 commits into
Draft
hyperrealist wants to merge 2 commits into
hyperrealist wants to merge 2 commits into
Conversation
The grid needed at least 3 setpoints on each axis, on the assumption that ViSR's plot needs three points per axis; it doesn't (2x2 and 1x1 images render), so 2x2 scans, line scans and single points fell back to the default 10x10 binning for no reason. Any grid size is now used. An axis with a single setpoint has no step of its own, so its cell takes the other axis's step (1 for a single point). Offsets still need a row to wrap before they are taken, so a fly scan along a single line keeps the default binning: on one row, an offset can't be told from a frame gained or lost at the start. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fy4Rv41HcbMRMkxzmCCJga
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 95.16% 95.22% +0.05%
==========================================
Files 5 5
Lines 766 775 +9
==========================================
+ Hits 729 738 +9
Misses 37 37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A run whose recorded positions include NaN (an x-only scan, where y is filled with NaN) made numpy's default binning fail to find a range, so /binned and /render answered 500. Points with no x or y position are now left out before binning; if that leaves none of a run's points, the answer is a 422 saying which positions are missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BsMDFhupHcBFbVJPK8QAvR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server-side work for the ViSR sprint, collected in one draft. Each feature is its own commit with its tests, so it can be reviewed, dropped or split out on its own. The UI side is DiamondLightSource/atlas#227.
4efd64b): 2×2 scans, line scans and single points get their own grid instead of the 10×10 fallback. An axis with one setpoint takes the other axis's step as its cell width.831578f): an x-only run (y all NaN) now gets a 422 saying the y positions are missing.Testing:
tox; each round is also checked against the ViSR UI running locally on the live b01-1 Tiled, and on the beamline from a test build before this leaves draft.🤖 Generated with Claude Code