Conversation
- parse LANG and issue warnings on improper styles - rewrite LANG -> USTY for apple2, c64, aambox - -iftf-sys-* platform overrides - foreground text color (c64) - warning options (see usage for flags)
Contributor
Author
|
But first I have to figure out why the gosling test fails with blank lines but not on my Mac :^P |
Contributor
|
This generally looks good to me! Just a few things:
|
Contributor
|
Oh, and one more thing: I think it's a bad idea to try to match hex color codes to the closest available fixed color. Better to make users explicitly acknowledge which color they want by name, which ensures they know about the limited palette available. |
Contributor
Author
|
I agree, RGB parsing is out for now. I added a spec and implemented the color: initial behavior. I made room for SET_BODY background colors, coming in a later PR :) Should I bump the minor version too? |
Contributor
Author
|
Not sure what's going on with the tests; the files are byte-identical on my Mac and Linux. |
Contributor
|
Hmm. That test failure is what I would expect if something was going wrong with div margins…in particular, that would match the old behavior where SPC was incorrectly set to PAR instead of LINE when leaving a div. |
Contributor
|
Otherwise, this all looks good! And yeah, I do think it's good to have this be version 1.1.0. |
Contributor
|
The tests also pass on my local machine. What's going on? |
Contributor
|
Oho, nope, I was able to reproduce the test failure, and I see the cause. The USTY chunk is not capturing top and bottom margins. Here's the LOOK chunk of gosling.aastory: And here's the USTY chunk of gosling.ustory: |
Contributor
|
If style warnings are not silenced: |
Contributor
|
And while I poke through gen_usty.c for this: I believe it should be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been sitting on this awhile, so time to PR! Apologies for the huge commit.
This patch parses the LANG chunk and replaces it with a binary USTY chunk which is now mandatory for apple2, c64, aambox.
The parsing is more complex than frontend.c, it supports RGB colors and gives warnings on lots of things.
You can also override styles with -iftf-sys--* syntax.
For example: "-iftf-sys-c64-color: red"
It also adds a foreground text color feature to C64, activated by the above syntax or just "color: red".
There is also a generic warning subsystem sort of based on the Dialog compiler, which might be overkill (--help-all shows all warning options)
Aamshow will decode the currently-versioned USTY chunk for debugging purposes.
The USTY format is documented a few times in the comments, but I don't know if a small internal spec might be better (since it'll change with new features)