ci: install PsExec directly with checksum verification - #1933
Conversation
The latest pstools Chocolatey package (1.2023.4.11) pins a SHA256 checksum for the upstream PSTools.zip, which Microsoft has since updated, so installation fails with a checksum mismatch and breaks CI. Version 1.2012.04.12 downloads the same HTTPS zip without a pinned checksum, so it installs the current PSTools reliably. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Let maintainers know that an action is required on their side
|
|
Implementation notes:
Note LLM-assisted content (no human feedback). |
There was a problem hiding this comment.
Pull request overview
Pins PSTools to an older Chocolatey package to restore the PEDM simulator CI job.
Changes:
- Pins PSTools to version
1.2012.04.12. - Documents the checksum mismatch workaround.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The pstools Chocolatey package downloads PSTools.zip from Microsoft at install time and pins a checksum that breaks whenever Microsoft updates the zip; the latest package version currently fails this way and older versions skip verification entirely. Download PSTools.zip directly from Microsoft and verify it against a checksum pinned in the workflow, so installs stay integrity-checked and the hash is bumped deliberately when Microsoft publishes a new PSTools. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Follow-up: replaced the version pin with a proper fix. Pinning pstools 1.2012.04.12 avoided the broken checksum only because that old package does no checksum verification at all, which is worse. New approach:
Verified locally: download, checksum match, extraction, and Note LLM-assisted content (no human feedback). |
1a4616e
into
master
The pstools Chocolatey package downloads PSTools.zip from Microsoft at install time and pins a checksum that breaks whenever Microsoft updates the zip; the latest package version currently fails this way and breaks the PEDM simulator CI job, while older versions skip verification entirely. Download PSTools.zip directly from Microsoft and verify it against a checksum pinned in the workflow, so installs stay integrity-checked and the hash is bumped deliberately when Microsoft publishes a new PSTools.