CardView - flaky tests in 26.1 - #35051
Open
bit-byte0 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is limited to test assertions intended to improve stability and does not alter product/runtime code paths.
Pull request overview
Stabilizes CardView TestCafe functional tests for the column chooser in select mode by adding pre-interaction assertions that leverage TestCafe’s auto-retry behavior, reducing click/rerender race conditions.
Changes:
- Adds an initial “first column is visible/checked” assertion immediately after opening the column chooser in the shared hide/show scenario.
- Adds explicit checkbox state assertions before and after toggling the first column in the “cards should update” select-mode test.
File summaries
| File | Description |
|---|---|
| e2e/testcafe-devextreme/tests/cardView/columnChooser/functional.ts | Adds state assertions around column chooser interactions to reduce flakiness from async re-render timing. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, test-only, and directly address flakiness by introducing stable, auto-retrying state assertions before/after interactions.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the flaky CardView column chooser select-mode functional tests stable
How
Waits for the column chooser to settle (auto-retrying checkbox-state assertions) before each interaction, so a click no longer races the asynchronous re-render