fix (demos): Workaround the broken pivotgrid demo - #35044
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped to re-enabling the previously-skipped demo by restoring a working Angular implementation and removing the now-unneeded skip logic.
Pull request overview
This PR restores the Angular PivotGrid “StandaloneFieldChooser” demo so it can be included again in the CSP bundle/check pipeline, removing the previous hardcoded skip that was masking the problem.
Changes:
- Removed the
SKIPPED_DEMOSworkaround soPivotGrid/StandaloneFieldChooser/Angularis again included incsp-checkand Angular CSP bundling. - Reimplemented the demo component to render the actual PivotGrid + standalone FieldChooser UI again.
- Adjusted Angular imports/bootstrapping to avoid the AOT duplicate nested-option component collision (NG8023) described in the prior placeholder implementation.
File summaries
| File | Description |
|---|---|
| apps/demos/utils/server/csp-check.js | Removes the skip list so the PivotGrid StandaloneFieldChooser Angular demo is checked again. |
| apps/demos/utils/server/csp-bundle-angular.js | Removes the skip list so the demo is bundled again for CSP verification. |
| apps/demos/Demos/PivotGrid/StandaloneFieldChooser/Angular/app/app.component.ts | Restores a working demo implementation and changes imports to avoid the AOT nested-option collision. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🔵 Needs a closer look
A type-widened layout property can trigger Angular template type-checking errors now that this demo is no longer skipped.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
apps/demos/Demos/PivotGrid/StandaloneFieldChooser/Angular/app/app.component.ts:42
layoutis used as the value fordx-pivot-grid-field-chooser'slayoutinput (typed asFieldChooserLayout = 0 | 1 | 2) and as thedx-radio-groupvalue. Declaring it as a plainnumberwidens the type and can cause Angular template type-checking errors; declare it asDxPivotGridTypes.FieldChooserLayoutto keep it compatible and self-documenting.
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🟢 Approval recommended
The change set is self-contained, removes temporary skip/workaround logic, and restores the demo in a way that aligns with existing Angular demo patterns in this repo.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently restore the previously disabled demo and remove the corresponding skip entries without introducing any verified functional issues in the modified code.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently re-enable the demo across bundling/CSP/testing and restore a working Angular implementation without introducing any verified issues in the touched areas.
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently re-enable the previously skipped demo across bundling/CSP/test layers while providing a complete Angular demo implementation with no evident compile-time or runtime issues in the reviewed diff.
Review details
- Files reviewed: 4/6 changed files
- Comments generated: 0 new
- Review effort level: Lite
No description provided.