Grids - DataController: Extract editing state knowledge to extenders - #35042
Open
Alyar666 wants to merge 1 commit into
Open
Grids - DataController: Extract editing state knowledge to extenders#35042Alyar666 wants to merge 1 commit into
Alyar666 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change cleanly relocates editing-specific logic into the editing extender and includes a focused regression test to cover the new behavior.
Pull request overview
Moves “cell modified” change detection out of the shared DataController and into the editing-specific data controller extender, so the base data layer no longer needs to know about editing state while editing behavior remains correct.
Changes:
- Extracted a shared
isCellModified(row, columnIndex)helper intom_editing_utils.ts. - Updated the editing data controller extender to treat modified-mark changes as a cell change (in addition to value changes).
- Simplified
DataController._isCellChangedto only compare cell values, and added a Jest regression test covering modified-mark-only updates.
File summaries
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/editing/m_editing_utils.ts | Adds isCellModified utility for checking modifiedValues per column. |
| packages/devextreme/js/__internal/grids/grid_core/editing/extenders/editing_data_controller.ts | Uses isCellModified to report per-cell changes when only the “modified” mark toggles. |
| packages/devextreme/js/__internal/grids/grid_core/editing/extenders/tests/editing_data_controller.row_changes.test.ts | Adds coverage ensuring a modified mark without a new value still reports the correct changed cell. |
| packages/devextreme/js/__internal/grids/grid_core/data_controller/data_controller.ts | Removes editing-specific modified mark logic from the base _isCellChanged implementation. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
anna-shakhova
approved these changes
Sep 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.