Grids - DataController: Extract row type knowledge to extenders - #35031
Open
Alyar666 wants to merge 2 commits into
Open
Grids - DataController: Extract row type knowledge to extenders#35031Alyar666 wants to merge 2 commits into
Alyar666 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The refactor cleanly moves row-type-specific logic into extenders with updated/added Jest tests covering the new behavior paths.
Pull request overview
This PR refactors row-change/diffing logic in the Grid DataController so that row-type-specific behavior (group rows, group footers, edit form rows) is handled by the relevant module extenders (grouping/summary/editing) rather than centralized in shared utilities.
Changes:
- Moved group-row column-diff logic into the DataGrid grouping extender and its utils (
getGroupColumnIndices). - Introduced
adjustInsertRowIndexin the baseDataController, with grouping extending the index adjustment to account for group rows. - Added/updated Jest coverage to validate row repaint vs partial cell updates for grouping, summary group footers, and form edit rows.
File summaries
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/editing/extenders/tests/editing_data_controller.row_changes.test.ts | Adds coverage ensuring form edit rows repaint fully (no column diff). |
| packages/devextreme/js/__internal/grids/grid_core/data_controller/utils/row_changes.ts | Removes group-specific helpers and replaces getDataRowIndex with generic countRowsBefore. |
| packages/devextreme/js/__internal/grids/grid_core/data_controller/utils/tests/row_changes.test.ts | Updates unit tests for the new countRowsBefore behavior and removes tests for deleted helpers. |
| packages/devextreme/js/__internal/grids/grid_core/data_controller/data_controller.ts | Adds adjustInsertRowIndex and simplifies core column diffing, delegating special cases to extenders. |
| packages/devextreme/js/__internal/grids/grid_core/tests/mock/helpers/row_changes.ts | Extends test helper to pass gridOptions and isLiveUpdate through refresh changes. |
| packages/devextreme/js/__internal/grids/data_grid/summary/extenders/summary_data_controller.ts | Overrides column diffing to force full repaint for DataGrid group footer rows. |
| packages/devextreme/js/__internal/grids/data_grid/summary/extenders/tests/summary_data_controller.row_changes.test.ts | Updates expectations to assert full-row repaint semantics for group footers. |
| packages/devextreme/js/__internal/grids/data_grid/grouping/utils.ts | Adds getGroupColumnIndices utility for group-row partial updates (skipping expand cell). |
| packages/devextreme/js/__internal/grids/data_grid/grouping/extenders/grouping_data_controller.ts | Implements grouping-specific insert index adjustment and group-row column diffing. |
| packages/devextreme/js/__internal/grids/data_grid/grouping/extenders/tests/grouping_data_controller.row_changes.test.ts | Adds coverage for group-row partial updates vs full repaint when not rendered. |
| packages/devextreme/js/__internal/grids/data_grid/grouping/extenders/tests/grouping_data_controller.data_row_index.test.ts | Adds coverage for grouping-aware insert index mapping. |
| packages/devextreme/js/__internal/grids/data_grid/grouping/tests/utils.test.ts | Adds unit tests for getGroupColumnIndices. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The refactor cleanly relocates row-type-specific behavior into appropriate extenders and is backed by targeted Jest tests covering the new/changed repaint and indexing behavior.
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 0 new
- Review effort level: Lite
anna-shakhova
approved these changes
Sep 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.