Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Nihad Uddin <nihad.uddin@rohde-schwarz.com>
Nihad74
force-pushed
the
api-key-comment-fix
branch
from
September 18, 2026 07:38
b06b1e8 to
8ad59a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes API key comments not updating immediately in the UI after being changed.
The API response for API keys without a comment does not include the
commentproperty. Since the frontend uses Vue 2, assigning the property directly later does not make it reactive. This change usesthis.$setwhen updating the API key comment so the UI is updated immediately.Addressed Issue
Fixes #1225
Additional Details
The original fix for v4 normalized missing API key comments to an empty string in multiple places.
For v5, the issue can be fixed more minimally at the point where the comment is updated:
This ensures that the comment property is reactive even when it was not present on the API key object initially.
Tested manually with:
Checklist