Skip to content

fix(docx): state the Word 2010 compatibility mode the export is measured against #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DemchaAV wants to merge 1 commit into from
Closed

fix(docx): state the Word 2010 compatibility mode the export is measured against #843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .../src/main/java/com/demcha/compose/document/backend/semantic/docx/DocxSemanticBackend.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,7 @@ private byte[] write(List<SemanticSection> sections, Path outputFile) throws Exc
}
hideTheClosingMark(document);
hideTheCellClosingMarks(document.getTables());
stateTheCompatibilityMode(document);
if (deterministicTimestamp != null) {
DocxDeterminism.pinCoreProperties(document, deterministicTimestamp);
}
Expand Down Expand Up @@ -929,6 +930,32 @@ private static boolean distinguishesEvenPages(List<SemanticSection> sections) {
return false;
}

/** The Word version whose layout the export is measured against: Word 2010's, 14. */
private static final String COMPATIBILITY_MODE = "14";

/**
* States the Word version whose layout rules the document follows ({@code w:compat}).
*
* <p>A document that states none is read in each editor's own default. Word 16 reads it in
* a compatibility mode in which a table's indent places its first cell's text; the
* LibreOffice build on the Linux CI reads it as a current document, in which the indent
* places the table's edge and the text a cell's margin further in: every panel in the body
* stood about a padding right of the page's there, and {@code ObsidianInvoice}'s items
* table 12.5pt. Stated, both read the document by the same rules. Written last in the
* settings, after everything POI writes there, where the schema orders it after them.</p>
*/
private static void stateTheCompatibilityMode(XWPFDocument document) {
String w = "http://schemas.openxmlformats.org/wordprocessingml/2006/main";
try (org.apache.xmlbeans.XmlCursor cursor = document.getSettings().getCTSettings().newCursor()) {
cursor.toEndToken();
cursor.beginElement(new javax.xml.namespace.QName(w, "compat", "w"));
cursor.beginElement(new javax.xml.namespace.QName(w, "compatSetting", "w"));
cursor.insertAttributeWithValue(new javax.xml.namespace.QName(w, "name", "w"), "compatibilityMode");
cursor.insertAttributeWithValue(new javax.xml.namespace.QName(w, "uri", "w"), "http://schemas.microsoft.com/office/word");
cursor.insertAttributeWithValue(new javax.xml.namespace.QName(w, "val", "w"), COMPATIBILITY_MODE);
}
}

/**
* Hides the mark of the empty paragraph a document ending in a table must end with.
*
Expand Down
Loading