Repository navigation
test(qa): hold a DOCX fidelity line where it stands across, as well as down - #834
Merged
Merged
Conversation
…t for the whole file, and count half a point in hundredths
… the fidelity gate counts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The DOCX fidelity corpus held each line to how far below the page's an editor set it, and nothing across. A table's left margin the export dropped stood
PaymentsInvoice's bank details 36.7pt andVioletGrid's education lines 51pt left of the page's in Word. Every line stayed at its height, so the gate passed both; #831 found them by hand.What changed
FidelityMeasurement.Found.across. Each found line also records how far right of the page's its first letter stands (editor'sxminus the engine's), from the glyph that already gives its baseline (PdfLines). The line file gains a column:document, line, drift, across, letters.FidelityBaseline.regressions. A line whose drift across grows by more thanLINE_SLACK(0.5pt) fails, as a line set lower does. The failure names it with… across.word-windows-lines.tsvandlibreoffice-windows-lines.tsvfrom local runs,libreoffice-linux-lines.tsvfrom this PR's CI artifactdocx-fidelity-37152419626. Their (document, line, drift) rows are identical to before, and the document files are unchanged.What it shows
Across the corpus the median line stands 0.07pt off across in Word and 0.10pt in LibreOffice on Windows. Lines more than 2pt off across, now held where they are: 175 in Word (33 documents), 130 in LibreOffice on Windows, 427 in LibreOffice on Linux. The ten documents with the most in Word:
cv-compact_monocv-teal_pulsecv-orange_opscv-panelinvoice-moderninvoice-paymentscv-executivecv-midnight_navycv-navy_sidebarinvoice-modern_longVerification
DocxFidelityGateTest, +6 tests (27):render-docx, the LibreOffice corpus gate fails exactlyVioletGrid(+0.10 → −51.25pt across),PaymentsInvoice(14 lines, → −36.6pt) andPlatformInvoice's footer (−1.2 → −1.8, −4.25 → −4.85pt). Restored afterwards.word-windows-lines.tsvis from a localscripts/docx-visual/word-fidelity.ps1 -Updaterun (Word 16.0.20430), checked again with a plain run.-Dgraphcompose.docxFidelity=libreoffice→ BUILD SUCCESS;scripts/docx-visual/word-fidelity.ps1→ BUILD SUCCESS../mvnw -B -ntp clean verify -pl :graph-compose-core,:graph-compose-render-pdf,:graph-compose-render-docx,:graph-compose-render-pptx,:graph-compose-templates,:graph-compose-testing,:graph-compose-qa,:graph-compose-coverage -am→ BUILD SUCCESS (qa 1820 tests).Notes
Lane: test (qa). No production code changes.