avaaaali - #103
Open
sowelipililimute wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
S: Untriaged
S: Needs Review
Changes: Sprites
Changes: Audio
size/L
and removed
S: Untriaged
S: Needs Review
labels
Contributor
|
RSI Diff Bot; head commit d531853 merging into 0e686ea Resources/Textures/_DVA/Mobs/Species/Avali/avali_crests.rsi
Resources/Textures/_DVA/Mobs/Species/Avali/avali_parts.rsi
Resources/Textures/_DVA/Mobs/Species/Avali/avali_stripes_one.rsi
Resources/Textures/_DVA/Mobs/Species/Avali/avali_trim_one.rsi
Resources/Textures/_DVA/Mobs/Species/Avali/avali_trim_two.rsi
Resources/Textures/_DVA/Mobs/Species/Avali/displacement.rsi
Resources/Textures/_DVA/Mobs/Species/Avali/feather.rsi
Resources/Textures/_DVA/Mobs/Species/Avali/parts.rsi
|
ShepardToTheStars
left a comment
ShepardToTheStars
left a comment
Contributor
There was a problem hiding this comment.
Species components need to be added to Resources/Prototypes/Entities/Mobs/Player/clone.yml as well.
Comment on lines
+19
to
+20
| [DataField] | ||
| public EntProtoId FeatherPrototype; |
Contributor
There was a problem hiding this comment.
Should this be required?
Comment on lines
+20
to
+21
| [DataField] | ||
| public EntProtoId FeatherPrototype; |
Contributor
There was a problem hiding this comment.
Should this be required?
Comment on lines
+49
to
+54
| if (comp.CurrentFeathers >= comp.MaximumFeathers) | ||
| { | ||
| comp.RegenerateAt = null; | ||
| Dirty(uid, comp); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Missing a continue in the Current >= Max block? Otherwise, an additional feather would get added even if they are at the maximum, right? (but only once since RegenerateAt would be null the next time that entity gets processed.
Alternatively, you could put the Current >= Max check above the comp.RegenerateAt == null as well.
| Dirty(uid, comp); | ||
| } | ||
|
|
||
| comp.CurrentFeathers += 1; |
Contributor
There was a problem hiding this comment.
Thoughts on clamping this to the max?
Suggested change
| comp.CurrentFeathers += 1; | |
| comp.CurrentFeathers = Math.Min(comp.CurrentFeathers + 1, comp.MaximumFeathers); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Well, the first species being brought over.
Technical details
DVGenericColorVisuals: generic visualizer for layer colour data because frankly im shocked this didnt exist yetDVInnateEyeOffset: system that augmentsEyeCursorOffsetw/ togglingDVToggleInnateEyeOffsetEventfor actionsDVPreenableComponent: handles spawning feathers w/ the right data and also the verb w/ a do-afterDVPreenOnDamaged: handles specifically triggering preens when hit by damageTest plan
Requirements
Licensing