Skip to content

style: improve fonts in app - #384

Merged
vitonsky merged 3 commits into
masterfrom
181-improve-fonts-in-app
Oct 14, 2026
Merged

vitonsky merged 3 commits into
masterfrom
181-improve-fonts-in-app

Conversation

@vitonsky

@vitonsky vitonsky commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Closes #181

Summary by CodeRabbit

  • Style
    • Updated the editor’s default font to Source Serif 4 and increased its default size from 16 to 18.
    • Note titles now use the selected editor font, and inline code and code blocks use Martian Mono.

@vitonsky vitonsky linked an issue Oct 14, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 265b2407-cb9f-4123-9211-1b3b3eac9f39
📥 Commits

Reviewing files that changed from the base of the PR and between 889660d and 4ad4dcb.

⛔ Files ignored due to path filters: 2
  • packages/app/assets/fonts/MartianMono-VariableFont_wdth,wght.woff2 is excluded by !**/*.woff2
  • packages/app/assets/fonts/SourceSerif4-VariableFont_opsz,wght.woff2 is excluded by !**/*.woff2
📒 Files selected for processing: 6
  • packages/app/assets/fonts.css
  • packages/app/src/features/NoteEditor/RichEditor/theme/RichEditor.css
  • packages/app/src/features/NoteEditor/index.tsx
  • packages/app/src/state/redux/settings/selectors/preferences.ts
  • packages/app/src/state/redux/settings/settings.ts
  • packages/app/src/templates/window.html

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The app now loads Martian Mono and Source Serif 4. The editor uses Source Serif 4 as its fallback font, sets the default font size to 18, applies the selected font to note titles, and uses Martian Mono for inline code and code blocks.

Changes: Editor typography

Layer / File(s) Summary
Font registration and loading
packages/app/assets/fonts.css, packages/app/src/templates/window.html
The stylesheet declares variable Martian Mono and Source Serif 4 fonts. The window template preloads both fonts and links the stylesheet.
Editor font defaults
packages/app/src/state/redux/settings/selectors/preferences.ts, packages/app/src/state/redux/settings/settings.ts
The editor font fallback changes to Source Serif 4, and the default editor font size changes from 16 to 18.
Editor font application
packages/app/src/features/NoteEditor/index.tsx, packages/app/src/features/NoteEditor/RichEditor/theme/RichEditor.css
The note title uses the Redux-selected editor font family. Inline code and code blocks use Martian Mono.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 4ad4d

The new fonts are available in production and the documented browser-development workflow, with no concrete merge-blocking risk identified.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: improving the application fonts.
Linked Issues check Passed Issue #181 requests research and improvement of font styles. The PR adds @font-face declarations for Martian Mono and Source Serif 4, preloads the fonts, applies Martian Mono to code styles, uses So…
Out of Scope Changes check Passed The reviewed changes stay within the font-improvement scope of issue #181. The CSS, font loading, editor font selection, code font styling, and default font-size changes all support the stated objecti…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vitonsky
vitonsky merged commit 0cce5a7 into master Oct 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve fonts in app

1 participant