Skip to content

style: make link are inline - #383

Merged
vitonsky merged 1 commit into
masterfrom
259-large-text-in-links-does-not-break-the-line
Oct 14, 2026
Merged

vitonsky merged 1 commit into
masterfrom
259-large-text-in-links-does-not-break-the-line

Conversation

@vitonsky

@vitonsky vitonsky commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Closes #259

Summary by CodeRabbit

  • Bug Fixes
    • Links in the rich-text editor now display inline with surrounding text rather than as inline blocks. This keeps links within the regular text flow and provides consistent formatting when links appear alongside other content.

@vitonsky vitonsky linked an issue Oct 14, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d41c00d6-2fdb-4576-afc4-ec1588f5c9a2
📥 Commits

Reviewing files that changed from the base of the PR and between f823558 and fd285da.

📒 Files selected for processing: 1
  • packages/app/src/features/NoteEditor/RichEditor/theme/RichEditor.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The rich editor changes .RichEditor__link from inline-block to inline.

Changes: Rich editor links

Layer / File(s) Summary
Link display mode
packages/app/src/features/NoteEditor/RichEditor/theme/RichEditor.css
.RichEditor__link now uses inline instead of inline-block.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to fd285

Rich-editor links can wrap with the existing text-breaking behavior, and the change does not establish a regression for links containing images. No concrete merge-blocking risk remains.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: changing links to use inline display. The grammar is imperfect, but the title is concise and specific.
Linked Issues check Passed Issue #259 identifies display: inline-block as the cause of the link wrapping problem. The PR changes .RichEditor__link to display: inline. This allows link text to participate in normal line wr…
Out of Scope Changes check Passed The PR changes one declaration in RichEditor.css. The change directly addresses the link rendering problem in issue #259. The reviewed summary shows no unrelated source, behavior, or dependency chan…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vitonsky
vitonsky merged commit 889660d into master Oct 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Large text in links does not break the line

1 participant