Repository navigation
Clarify store address collisions and hide connection actions - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves store creation safety and user feedback by adding explicit checks for store address reuse and deletion in the store admission logic. It also updates related tests and documentation to reflect these enhancements.
Store admission and error handling improvements:
requestStorefunction now checks if a store slug is already present in the database before proceeding. If the slug exists with aDeletingstatus, it returns a clear error message instructing the user to wait before retrying; otherwise, it reports that the store name is already in use.Test suite and fixture updates:
tests/store-requests.test.tswas extended to handle store records withslugandstatus, and to simulate the new slug/status check in queries. [1] [2] [3]Deletingis blocked across teams, and that the slug can be reused once deletion is complete.Documentation improvements:
docs/verification.mdwas rewritten for clarity, summarizing key checks, recovery/isolation scenarios, deterministic coverage, and evidence scope.