Fail build app when provider file writes fail#89
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Cole Collins <DealPatrol@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
The build-app SSE route treated GitHub/GitLab file push failures as successful writes. A provider rejection (permissions, branch/path conflict, rate limit, etc.) was only logged, then the route incremented the pushed count and emitted
step: "done", causing users to see a successful build even when the remote repo was incomplete or broken.Root cause
pushFileToGitHubandpushFileToGitLabreturned normally on non-2xx provider responses. The route also converted file generation failures into placeholder error files and continued to report success.Fix
lib/build-app-platforms.ts./api/build-appto emitstep: "error"and stop on generation or push failure instead of pushing placeholders or reportingdone.finallyblock.Validation
pnpm exec tsc --noEmitGitHub rejected README.md: Protected branch