Repository navigation
release: 1.9.1, do not merge until npm view returns 1.9.1 - #690
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
In 1.9.0, one run that selected no tests and exited 0 made "All tests pass" SUPPORTED. A note said it showed only that the command passed, but the word claimed more than an exit code can show. TrustShell records how a command ended and cannot tell whether it tested anything. Reports move to schema 0.2-draft. verify rebuilds a report under its own schema, so a folder made by 1.9.0 keeps its word and still verifies; a real one from the published package is pinned as a fixture. Its bytes must stay exact, so the fixture is marked -text. The release test gains four steps, run on the packed artifact: an empty run, a failure then an easier run, a swapped script, and its claim. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8c2f4c2 to
8f58c05
Compare
Publish from this commit, then merge: the docs here say 1.9.1 is on npm. Against the published 1.9.0 tarball, five files differ: the changelog, the README's version pins, package.json's version and the trust-report build with its types. 165 files, 21 MCP tools. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Strix Security Review✅ No open security findings. PR summary: Release 1.9.1 of @hyperdag/trustshell: a claim paired with a command that exited 0 now reads COMMAND_PASSED instead of SUPPORTED, reports move to schema 0.2-draft while `verify` still accepts and rebuilds 1.9.0-era 0.1-draft folders, and the release test gains five steps on the packed artifact. Review summaryReviewed the 1.9.1 release diff: the Trust Report status change (a bound claim whose command exited 0 now reads COMMAND_PASSED instead of SUPPORTED), the new 0.2-draft schema with a 0.1-draft compatibility path in Ruled out (5)
Review 1 on this PR · Reviewed by Strix |
There was a problem hiding this comment.
Reviewed the 1.9.1 release diff: the Trust Report status change (a bound claim whose command exited 0 now reads COMMAND_PASSED instead of SUPPORTED), the new 0.2-draft schema with a 0.1-draft compatibility path in verify, the browser viewer's widened schema acceptance, the new release-e2e steps, the byte-pinned 1.9.0 fixture, and the version pins across docs and skills. The security-relevant question is whether the schema field taken from an untrusted report.json can be used to launder COMMAND_PASSED back into SUPPORTED; it cannot, because report.json is listed in MANIFEST.sha256 and the manifest digest is Ed25519-sealed and checked against the caller's pinned --root, and flipping the schema also breaks the byte-for-byte rebuild. The committed dist/ was verified byte-identical to a fresh tsc build of the changed source and to the packed tarball, so the published artifact matches the reviewed code. No vulnerabilities found.
Reviewed by Strix
Configure security review settings
Do not merge until
npm view @hyperdag/trustshell versionreturns 1.9.1. This branch is what gets published, and its docs say 1.9.1 is on npm.In 1.9.0, one
trustshell runthat selected no tests and exited 0 made "All tests pass" SUPPORTED. A note beside it said this showed only that the command passed, but the word claims more than an exit code can show. TrustShell records how a command ended and cannot tell whether it tested anything.What changes
0.2-draft.verifyrebuilds a report under its own schema, so a folder made by 1.9.0 keeps its word and still verifies.Against the published 1.9.0 tarball, five files differ:
CHANGELOG.md,README.md(version pins),package.json(version) anddist/cli/trust-report.jswith its.d.ts. None added, none removed.Evidence
-text.Limits
COMMAND_PASSED is still shown in the "good" colour and still exits 0. It means the command ended cleanly, nothing more, and the report says so. The separate scripted attack that 1.8.0 received has not been run on this tarball.
🤖 Generated with Claude Code