Repository navigation
t12(T12-L07): Pin how the package version is resolved - #685
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🧾 Receipt1 claim(s) checked against GitHub's own check runs on
What this receipt does not prove
Receipts by TrustShell. Read-only: it reads this PR and its check runs, and writes only this comment. No code leaves the repo. |
Strix Security Review✅ No open security findings. PR summary: Adds a Jest test file that pins how `resolvePackageVersion` resolves the package version from package.json, including the `"unknown"` fallbacks for empty, non-string, and missing versions. Review summaryThis PR adds a single Jest unit test, Review 1 on this PR · Reviewed by Strix |
There was a problem hiding this comment.
This PR adds a single Jest unit test, tests/version-resolve.test.ts, pinning the contract of the existing resolvePackageVersion helper in src/lib/version.ts (returns the package.json version string, or "unknown" for empty, non-string, or missing versions). No production code, configuration, dependency, or build/CI behavior is changed, and the test only exercises a pure read-and-parse helper against a temporary directory. Lint triage of all 147 items found nothing in the changed file or its import closure (the helper imports only node:fs and node:path); the only related items are pre-existing findings in unrelated callers. No security issues found in the changed code.
Reviewed by Strix
Configure security review settings
T12 lane deliverable for T12-L07. Checked by a fresh-checkout re-run at b0461f1, with a negative control. That proves the test passes with this change and fails without it, not that the test is good. Review before merging.