Repository navigation
fix: reject invalidated draft confirmations with conflict - #278
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a confirmed draft previously erased its confirmation ID, so stale saves returned 400 while U03 requires 409. Persist a private invalidation marker across edits, exclude it from public metadata, and require fresh confirmation before saving. Missing or unrelated confirmation remains 400; stale and expired confirmation returns 409/40900 with no business write.
Validation: remote RED reproduced the prior 400 response. Exact b28ba8d remote full Agent suite: 1708 passed, 1 optional Qdrant skip (134.60s). Independent review approved the final code, contract documentation, security regression and synchronized corpus fingerprint. CI 38143772077 is still running; Agent CI passed. Formal U03 remains incomplete and historical U02 evidence is not relabeled for this candidate.