Repository navigation
Vue3/use address search functionality withing routing plugin - #947
Open
jedi-of-the-sea wants to merge 97 commits into
Open
jedi-of-the-sea wants to merge 97 commits into
jedi-of-the-sea wants to merge 97 commits into
Conversation
|
…arch result component
jedi-of-the-sea
marked this pull request as ready for review
October 21, 2026 12:31
jedi-of-the-sea
requested review from
czirkelbach,
dopenguin,
oeninghe-dataport,
raschju and
warm-coolguy
as code owners
October 21, 2026 12:31
…ch-functionality-withing-routing-plugin
…ch-functionality-withing-routing-plugin
…ch-functionality-withing-routing-plugin
…ch-functionality-withing-routing-plugin
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
addressSearchfunctionality can now used inroutingifreversedGeocoderis implemented´as well. AsearchGroupIdcan be configured inrouting, otherwise thedefaultGroupis used.For testing, I used a more extensive
addressSearchconfiguration with several groups and categories to see the impact on the routing plugin:Details
I also added
searchGroupId: 'address'to the routing plugin configuration to specify the group that should be used for a search. As my search configuration does not include a default group, this must be defined for routing, otherwise the search will not work.This PR should also fix a bug in routing:
reproduce in
next:fyi: to prevent another bug, i removed the check for incomplete routes, but I am not sure if this is necessary to prevent to many requests to the API and risk getting blocked for the rest of the day. I leave it out for now, but if reviewer says it should stay in, I'll add it again.
Instructions for local reproduction and review
Pull Request Checklist (for Assignee)
Changelogs are maintainedSafariFunctionality has been tested on a smartphoneUI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)
Relevant tickets, issues, et cetera
Issue #865