fix(doctor): (map,name)-keyed union, linear JSONC, wider invisible-char alphabet (DSE-1529) - #103
Merged
Merged
Conversation
…ar alphabet (DSE-1529) Follow-ups from the CSO final pass of #98. is no longer a reserved namespace: entries are keyed on (map, name) and the display key is derived afterwards, unique by construction, so a user-named is neither overwritten nor falsely flagged; ambiguity is recorded per display key. is a single string-aware linear pass (split into doctor_jsonc.py for the LOC budget) — the regex form went quadratic on unterminated . also neutralises U+00AD, U+2060–U+2064, U+FEFF and the Unicode Tags block. DOCTOR.md documents --config de-duplication/replacement and the safe_text caveat on printed URLs.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the Low/Info residuals from the CSO final pass of #98 (DSE-1529).
Acceptance criteria
(map, name); a user-namedx#serversis neither dropped nor falsely flagged; tests for both directions (test_user_named_hash_servers_entry_is_neither_dropped_nor_flagged,test_user_named_hash_servers_alone_is_not_flagged_ambiguous). Ambiguity is derived from the display keys of the colliding pair, not a#serverssuffix rule.strip_jsonclinear on pathological input — one string-aware left-to-right pass (comments + trailing commas together), split intodoctor_jsonc.pyfor the LOC budget;test_strip_jsonc_is_linear_on_unterminated_block_comments(600 KB of/*with no*/, < 2 s, left untouched → fails closed) + a comment-between-comma-and-close case.docs/DOCTOR.mddocuments--configresolved-path de-duplication / explicit-replaces-discovered and thesafe_textcaveat on printed URLs._CONTROLextended with U+00AD, U+2060–U+2064, U+FEFF, U+E0000–U+E007F; parametrizedtest_invisible_format_characters_are_neutralised.Verification (dse-builder-01, py3.12)
ruff check .cleanCOVERAGE_PROCESS_START=pyproject.toml): 1095 passed, 2 skipped, 87% (floor 80). 8 builder-only failures intest_precommit/test_signing(barepythonresolves the system 3.12 there); re-run with the venv onPATH→ 52 passed, 1 skipped. CI'ssetup-pythonis unaffected.doctor_discovery.py237,doctor_jsonc.py80,doctor.py210,doctor_funnel.py182)🤖 Generated with Claude Code
https://claude.ai/code/session_01Lu4ZLyWWL7TXMGYpNFU5Dc