attester: matrix carries coordinates only (runner masks outputs that look like secrets) - #4
Merged
Merged
Conversation
…tputs that look like secrets Full run 33751412167: 'Skip output matrix since it may contain secret' — the dummy credentials in targets.yaml env tripped the runner heuristic, so no attest job was created. Each attest job now re-reads its target from targets.yaml by coordinate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full run 33751412167 created zero attest jobs: the runner skipped the
matrixoutput because the dummy credentials inenvlook like secrets. The matrix now holds only coordinates and each job re-reads spawn/env from the checked-out targets.yaml (plan.py --one).